Add unit tests for addReply function
#115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
gpunto
reviewed
Oct 16, 2025
...lient/src/test/kotlin/io/getstream/feeds/android/client/api/model/ThreadedCommentDataTest.kt
Outdated
Show resolved
Hide resolved
...lient/src/test/kotlin/io/getstream/feeds/android/client/api/model/ThreadedCommentDataTest.kt
Outdated
Show resolved
Hide resolved
...lient/src/test/kotlin/io/getstream/feeds/android/client/api/model/ThreadedCommentDataTest.kt
Outdated
Show resolved
Hide resolved
...lient/src/test/kotlin/io/getstream/feeds/android/client/api/model/ThreadedCommentDataTest.kt
Outdated
Show resolved
Hide resolved
gpunto
reviewed
Oct 20, 2025
...lient/src/test/kotlin/io/getstream/feeds/android/client/api/model/ThreadedCommentDataTest.kt
Outdated
Show resolved
Hide resolved
aleksandar-apostolov
changed the title
addReply function
Co-authored-by: Gianmarco <[email protected]>
gpunto
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Add unit tests for the
addReplyfunction to ensure it correctly appends replies and updates the replyCount, while maintaining the order of repliesImplementation
Created two test cases for the
addReplyTesting
Ran unit tests to confirm:
replyCount is correctly incremented.
The replies list contains the new reply.
Replies are sorted correctly according to the comparator.
Checklist